Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifests: add missing namespace on opentelemetry-demo-grafana-dashboards configmaps #1337

Closed
wants to merge 1 commit into from

Conversation

hsinhoyeh
Copy link

Changes

add missing namespace to opentelemetry-demo-grafana-dashboards configmaps

fixes: #1336

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@hsinhoyeh hsinhoyeh requested a review from a team January 17, 2024 03:39
@puckpuck
Copy link
Contributor

This is a generated file from the Helm install. We need to figure out how to ensure we have the proper output while generating it.

make generate-kubernetes-manifests is what's used to generate the file.

@hsinhoyeh
Copy link
Author

This is a generated file from the Helm install. We need to figure out how to ensure we have the proper output while generating it.

make generate-kubernetes-manifests is what's used to generate the file.

generate-kubernetes-manifests

ic, then the fix should be here: https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/charts/opentelemetry-demo/templates/grafana-dashboards.yaml#L5

@hsinhoyeh
Copy link
Author

@puckpuck please check this patch on helm-chart https://github.com/open-telemetry/opentelemetry-helm-charts/pull/1002/files

then we can proceed update the generated manifests here after it has landed.

@puckpuck puckpuck closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kubernetes] missing namespace for configmap opentelemetry-demo-grafana-dashboards
2 participants