refactor(productcatalogservice): use //go:embed directive for products.json

[tranngoclam]

Changes

• Apply //go:embed directive to store the products.json data, by doing this we don't need to COPY the json file into container image.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

• CHANGELOG.md updated to document new feature additions
• Appropriate documentation updates in the docs
• Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

[puckpuck]

Hmmm. I have a PR I'm tee-ing up that takes advantage of this being copied into the container so users can modify the products list at runtime.

Doing this embed would not allow that to be possible.

[tranngoclam]

Hmmm. I have a PR I'm tee-ing up that takes advantage of this being copied into the container so users can modify the products list at runtime.

Doing this embed would not allow that to be possible.

@puckpuck it's fine, so let close my PR