Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker compose): add container name as tag attribute to contain… #1495

Merged
merged 5 commits into from
Apr 6, 2024

Conversation

harrykimpel
Copy link
Contributor

…er logs

Changes

Added a minor change to docker-compose.yml

Please provide a brief description of the changes here.
Added some configuration to docker-compose.yml in order to add the respective container name as tag attribute to container logs

Merge Requirements

Due to the minor update to docker-compose.yml, no changes necessary to Demo Helm chart.

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@harrykimpel harrykimpel requested a review from a team April 3, 2024 13:06
@puckpuck
Copy link
Contributor

puckpuck commented Apr 4, 2024

Please do the same change to docker-compose-minimal.yml.

@harrykimpel
Copy link
Contributor Author

Please do the same change to docker-compose-minimal.yml.

@puckpuck done

@austinlparker austinlparker merged commit 888f18c into open-telemetry:main Apr 6, 2024
25 of 26 checks passed
AlexPSplunk pushed a commit to splunk/edu-opentelemetry-demo that referenced this pull request Jul 10, 2024
open-telemetry#1495)

* chore(docker compose): add container name as tag attribute to container logs

Signed-off-by: Harry Kimpel <[email protected]>

* chore(docker compose): add container name as tag attribute to container logs

Signed-off-by: Harry Kimpel <[email protected]>

* chore(docker compose): add container name as tag attribute to container logs

Signed-off-by: Harry Kimpel <[email protected]>

---------

Signed-off-by: Harry Kimpel <[email protected]>
Co-authored-by: Austin Parker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants