[chore] multi platform builds #1651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
helm-update-required
…o chore.multi-platform-builds
puckpuck
removed
the
helm-update-required
There was a problem hiding this comment.
@puckpuck when testing this change locally on a M1, I lost the accountingservice traces.
# Conflicts: # CHANGELOG.md # Makefile # docker-compose-tests.yml
|
I need to work with someone more familiar with the .NET auto-instrumentation and using it in multi-platform builds. I can get it to emit traces or build/run multi-platform, but not both. I'll convert this to a draft until I can figure out that part. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed because Pierre is on holidays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes: #1629
This provides platform-specific changes to the
Dockerfiledefinition for several services to ensure they will be built in linux/amd64 and linux/arm64 platforms. I also cleaned up old Makefile targets for building and pushing images before we moved to GitHub Actions for this repo.This change also splits the tests into a separate
docker-compose-tests.ymlfile. This new file references the standarddocker-compose.ymlfile on include and is used only for testing.Mutli-platform builds were tested on Apple M2 MacBook and an Ubuntu 22.04 VM running on an Intel NUC.
Merge Requirements
For new feature contributions, please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additions* [ ] Appropriate documentation updates in the docs* [ ] Appropriate Helm chart updates in the helm-chartsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.