Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[checkout] update grpc clients #1695

Closed
wants to merge 2 commits into from

Conversation

puckpuck
Copy link
Contributor

Changes

Updates Go gRPC client calls to move away from deprecated DialContext in favor of NewClient call.

The productcatalogservice also had code for this call, but it was in an unused function, so I just removed that function. This makes sense, since productcatalog doesn't make any client calls.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
    * [ ] Appropriate documentation updates in the docs
    * [ ] Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@puckpuck puckpuck requested a review from a team July 31, 2024 01:54
@puckpuck puckpuck closed this Jul 31, 2024
@puckpuck puckpuck deleted the go.update-grpc-clients branch July 31, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant