Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add yamllint to make all #1707

Merged

Conversation

CodePrometheus
Copy link
Contributor

Changes

Add yamllint to make all, and adjust the logic for installing yamllint.

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@CodePrometheus CodePrometheus requested a review from a team August 25, 2024 08:17
Copy link

linux-foundation-easycla bot commented Aug 25, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: CodePrometheus / name: Starry (7f84a3e, 01e9a0e)
  • ✅ login: julianocosta89 / name: Juliano Costa (295b82c)

@CodePrometheus
Copy link
Contributor Author

@austinlparker Teacher Austin, could you please help review the code, thanks.

Makefile Outdated Show resolved Hide resolved
@julianocosta89 julianocosta89 merged commit 41e3673 into open-telemetry:main Aug 27, 2024
28 checks passed
@CodePrometheus CodePrometheus deleted the feat-makefile-yamllint branch August 27, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants