Remove setting http.route attribute in frontend
#566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the OpenTelemetry HTTP Server semantic conventions, `HTTP.ROUTE` is meant to be a low cardinality route template. The URI cannot substitute it. This patch remove the usage of the HTTP_ROUTE semantic attribute.
puckpuck
approved these changes
Nov 9, 2022
AbhiPrasad
force-pushed
the
http-route-remove-low-cardinality
branch
from
088b8f0
to
3b1437d
Compare
julianocosta89
approved these changes
Nov 10, 2022
|
Do I need to do anything else to get this merged in? Or is there some release cadence we need to follow here? |
Just update the branch and for future prs please use a personal fork. We can’t trigger branch updates on an organizational fork. Should be good to go after that |
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
As per the OpenTelemetry HTTP Server semantic conventions, `HTTP.ROUTE` is meant to be a low cardinality route template. The URI cannot substitute it. This patch remove the usage of the HTTP_ROUTE semantic attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As per the OpenTelemetry HTTP Server semantic conventions, the
http.routeattribute is meant to be a low cardinality route template. The URI cannot substitute it.This patch remove the setting of the
http.routesemantic attribute by the Instrumentation Middleware in the frontend service.Trying to get a paramaterized template route in NextJS is incredibly difficult (take a look at getsentry/sentry-javascript#5505 to see what it takes), so I did not replace it with anything. This seems to be fine since as per the semantic convention is the
http.routeattribute is "Conditionally Required: If and only if it's available"Two notes:
SemanticAttributes.HTTP_TARGETto be the url? This seems to match the semantic conventions better.