[Instrumentation.Http] Skip tagging traces when running on .NET 9+ #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
infra
Kielek
reviewed
Nov 12, 2024
TimothyMothra
requested a deployment
to
external
GitHub Actions
Waiting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2314 +/- ##
==========================================
- Coverage 73.91% 67.96% -5.95%
==========================================
Files 267 363 +96
Lines 9615 13512 +3897
==========================================
+ Hits 7107 9184 +2077
- Misses 2508 4328 +1820
Flags with carried forward coverage won't be shown. Click here to find out more.
|
TimothyMothra
requested a deployment
to
external
GitHub Actions
Waiting
…mothyMothra/opentelemetry-dotnet-contrib-fork into 2029_httpinstrumentation_net9
alanwest
reviewed
Nov 16, 2024
alanwest
reviewed
Nov 16, 2024
Co-authored-by: Alan West <[email protected]>
Thanks!
Sigh. Visual Studio keeps saving files with Windows line endings (CR LF), but this repo expects Unix line endings (LF). |
…mothyMothra/opentelemetry-dotnet-contrib-fork into 2029_httpinstrumentation_net9
CodeBlanch
reviewed
Nov 25, 2024
src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
CodeBlanch
changed the title
cijothomas
reviewed
Dec 2, 2024
| @@ -199,16 +203,19 @@ public void OnStopActivity(Activity activity, object? payload) | |||
|
|
|||
| if (TryFetchResponse(payload, out var response)) | |||
| { | |||
| if (currentStatusCode == ActivityStatusCode.Unset) | |||
| if (!IsNet9OrGreater) | |||
There was a problem hiding this comment.
Activity status, error.type are still set above in .NET9. is that intended?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2029
Net9 added support for Http semantic convention attributes here: dotnet/runtime#104251
Changes
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes