Skip to content

Commit

Permalink
[repo] Add .NET 8 target for W3C Trace Context Integration Test in CI (
Browse files Browse the repository at this point in the history
…#5800)

Co-authored-by: Piotr Kiełkowicz <[email protected]>
  • Loading branch information
xiang17 and Kielek authored Sep 4, 2024
1 parent 1479686 commit dc8d3fd
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ jobs:
strategy:
fail-fast: false
matrix:
version: [ net6.0 ]
version: [ net6.0, net8.0 ]
steps:
- uses: actions/checkout@v4
- name: Run W3C Trace Context docker compose
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ COPY --from=w3c /w3c .
RUN apt-get update \
&& apt-get install -y python3-pip python3-dev \
&& cd /usr/local/bin \
&& ln -s /usr/bin/python3 python \
&& pip3 install --upgrade pip \
&& pip3 install aiohttp
&& ln -s /usr/bin/python3 python

# net6.0 image uses Python 3.9, which doesn't have `--break-system-packages` option.
RUN pip3 install --upgrade pip --break-system-packages || pip3 install --upgrade pip
RUN pip3 install aiohttp --break-system-packages
ENTRYPOINT ["dotnet", "vstest", "OpenTelemetry.Instrumentation.W3cTraceContext.Tests.dll", "--logger:console;verbosity=detailed"]
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public void W3CTraceContextTestSuiteAsync(string value)
return result;
});

app.RunAsync();
app.RunAsync("http://localhost:5000/");

string result = RunCommand("python", "trace-context/test/test.py http://localhost:5000/");

Expand Down

0 comments on commit dc8d3fd

Please sign in to comment.