Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTracing Shim: ScopeManager.Activate can throw if span is not sampled #4728

Open
pjanotti opened this issue Jul 28, 2023 · 5 comments · May be fixed by #6123
Open

OpenTracing Shim: ScopeManager.Activate can throw if span is not sampled #4728

pjanotti opened this issue Jul 28, 2023 · 5 comments · May be fixed by #6123
Labels
bug Something isn't working

Comments

@pjanotti
Copy link
Contributor

The current implementation of ScopeManager uses a ConditionalWeakTable to associate an Activity to a SpanShim. However, if the Activity used by the shim is not being sampled the associated Activity will be the singleton TelemetrySpan.NoopInstance and the Add method on ConditionalWeakTable will throw an exception. Repro test: 57845b2#diff-64d0dfb854bfa159bf2bfd49d7349af30848d52f4b9147e47e423b1e2d3399adL31
@pjanotti pjanotti added the bug Something isn't working label Jul 28, 2023
@Kielek Kielek mentioned this issue Aug 7, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

This issue was marked stale due to lack of activity and will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this issue is still a concern.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 23, 2024
@konczykl
Copy link

konczykl commented Feb 4, 2025

This is still a problem.

@Kielek Kielek reopened this Feb 4, 2025
@Kielek Kielek removed the Stale Issues and pull requests which have been flagged for closing due to inactivity label Feb 4, 2025
@Kielek
Copy link
Contributor

Kielek commented Feb 4, 2025

@konczykl, would you like to contribute some fixes?

@konczykl konczykl linked a pull request Feb 4, 2025 that will close this issue
Open
@konczykl
Copy link

konczykl commented Feb 4, 2025

@Kielek see PR #6123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ScopeManagerShim - do not store not recorded spans konczykl/opentelemetry-dotnet
3 participants
@pjanotti @Kielek @konczykl