ScopeManagerShim - do not store not recorded spans #6123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
pkg:OpenTelemetry.Shims.OpenTracing
|
@konczykl, signing EasyCLA is hard step before we can consider any new contribution. Could you please handle it? |
pjanotti
approved these changes
Feb 6, 2025
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
|
@konczykl, could you please check EasyCLA requierements? |
github-actions
bot
removed
the
Stale
konczykl
force-pushed
the
fix/scope-manager-shim-noopinstance-ref
branch
from
3f13bcd to
f6f917a
Compare
|
@konczykl, please check CI issues. Executing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4728
Changes
Do not store not recorded spans in
ScopeManagerShim- they are not returned anyway and those spans were often static fieldTelemetrySpan.NoopInstancethat throws exception Key already has been added.