Add activity user guide link in README. #1857
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cijothomas
reviewed
Feb 26, 2021
| documented fully in the [activity user guide](https://github.com/dotnet/corefx/blob/master/src/System.Diagnostics.DiagnosticSource/src/ActivityUserGuide.md), but is described | ||
| here as well. | ||
| documented fully in the | ||
| [activity user guide](https://github.com/dotnet/corefx/blob/master/src/System.Diagnostics.DiagnosticSource/src/ActivityUserGuide.md), |
Member
There was a problem hiding this comment.
this is the old link, which doesn't contain the current recommendation of using ActivitySource.
https://docs.microsoft.com/dotnet/core/diagnostics/distributed-tracing#getting-started-with-tracing is the right link.
Member
|
@plmaheu Will you be updating the link to the correct one ? |
Member
|
Closing this PR. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #.
Changes
Fix TBD in docs by adding link.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes