Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for batch span processor env vars #2228

Conversation

dszmigielski
Copy link
Contributor

Partially addresses #1453.

This feature is important so that we can reuse the SDK in https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation.

Changes

The BatchExportProcessorOptions defaults can be overridden using environmental variables as defined in the specification.

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@dszmigielski dszmigielski requested a review from a team August 4, 2021 10:59
@reyang
Copy link
Member

reyang commented Aug 4, 2021

Is this duplicated with #2219?

@dszmigielski
Copy link
Contributor Author

Is this duplicated with #2219?

Yep, it seems so... I didn't see that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants