[HttpClient & Asp.Net Core] Update Readme.md #5168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishweshbankwar
changed the title
cijothomas
reviewed
Dec 13, 2023
cijothomas
reviewed
Dec 13, 2023
cijothomas
reviewed
Dec 13, 2023
cijothomas
reviewed
Dec 13, 2023
| [v1.23](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http) | ||
| of http semantic conventions. | ||
|
|
||
| Following list of attributes are added by default on activity. See |
There was a problem hiding this comment.
split it under tracing, metrics heading separately to make it easy to follow.
There was a problem hiding this comment.
I moved it under traces and metrics below. Please check if that will be more clear.
cijothomas
approved these changes
Dec 14, 2023
utpilla
reviewed
Dec 14, 2023
|
|
||
| gRPC instrumentation can be enabled by setting | ||
| `OTEL_DOTNET_EXPERIMENTAL_ASPNETCORE_ENABLE_GRPC_INSTRUMENTATION` flag to | ||
| `True`. The flag can be set as an environment variable or via IConfiguration as |
There was a problem hiding this comment.
nit: Use the same casing throughout the doc. The code snippet below uses true.
utpilla
reviewed
Dec 14, 2023
| @@ -66,6 +61,26 @@ public void ConfigureServices(IServiceCollection services) | |||
| } | |||
| ``` | |||
|
|
|||
| Following list of attributes are added by default on activity. See | |||
There was a problem hiding this comment.
A lot of these attributes are only added when they are available. For example, error.type, user_agent.original etc.
Suggested change
| Following list of attributes are added by default on activity. See | |
| When available, the following list of attributes are added by default on activity. See |
utpilla
reviewed
Dec 14, 2023
| @@ -65,6 +57,22 @@ public class Program | |||
| } | |||
| ``` | |||
|
|
|||
| Following list of attributes are added by default on activity. See | |||
There was a problem hiding this comment.
utpilla
approved these changes
Dec 14, 2023
|
@vishweshbankwar Left some suggestions that could be addressed in a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes