[Editorial] Update the docs based on Copilot review feedback #5332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
approved these changes
Feb 9, 2024
rajkumar-rangaraj
approved these changes
Feb 9, 2024
vishweshbankwar
approved these changes
Feb 9, 2024
utpilla
reviewed
Feb 9, 2024
| the hot-path. You SHOULD try to keep the number of tags less than or equal to 8. | ||
| If you are exceeding this, check if you can model some of the tags as Resource, | ||
| as [shown here](#metrics-enrichment). | ||
| the hot code path. You SHOULD try to keep the number of tags less than or |
There was a problem hiding this comment.
It's probably better to keep it as hot-path instead of "hot code path"?
There was a problem hiding this comment.
CoPilot recommends against "hot-path", a quick search shows that "hot path" and "hot code path" are widely used. e.g. https://www.hackterms.com/hot%20code
utpilla
approved these changes
Feb 9, 2024
CodeBlanch
reviewed
Feb 9, 2024
Co-authored-by: Mikel Blanchard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.