Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MinVerTagPrefix for SQL and gRPC instrumentation #5337

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

alanwest
Copy link
Member

@alanwest alanwest commented Feb 9, 2024

In prep for release #5322.

SQL and gRPC instrumentation has not yet received a release that aligns major/minor version with the 1.7 API/SDK release.

@alanwest alanwest requested a review from a team February 9, 2024 19:01
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch added area:instrumentation infra Infra work - CI/CD, code coverage, linters labels Feb 9, 2024
@utpilla
Copy link
Contributor

utpilla commented Feb 9, 2024

@alanwest We could probably use a dedicated tag for Shims.OpenTracing as well (just for consistency)?

Would you want to update the RELEASING docwith these changes?

…Instrumentation.GrpcNetClient.csproj

Co-authored-by: Utkarsh Umesan Pillai <[email protected]>
@alanwest
Copy link
Member Author

alanwest commented Feb 9, 2024

Would you want to update the RELEASING docwith these changes?

Yep, sounds good. I'm going to first focus on getting the release out, but I will follow up with updating our release instructions.

@alanwest alanwest merged commit 8325786 into open-telemetry:main Feb 9, 2024
42 of 44 checks passed
@alanwest alanwest deleted the alanwest/minvertags branch February 9, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants