OpenTracing shim should use core MinVerTagPrefix #5339
Conversation
| @@ -3,6 +3,7 @@ | |||
| <TargetFrameworks>$(TargetFrameworksForLibraries)</TargetFrameworks> | |||
| <Description>OpenTracing shim for OpenTelemetry .NET</Description> | |||
| <PackageTags>$(PackageTags);distributed-tracing;OpenTracing</PackageTags> | |||
| <MinVerTagPrefix>core-</MinVerTagPrefix> | |||
There was a problem hiding this comment.
For this package, we had made a decision to only have beta releases as we previously considered it a non-core component. With this change, we would be redefining the stability readiness of this package as it would now begin to have alpha, beta, and rc releases (similar to Prometheus Exporter packages).
We even had an entry describing this decision in the CHANGELOG:
The pre-release identifier has also been changed from rc to beta as we believe this more accurately reflects the status of this package. We believe the rc identifier will be more appropriate as semantic conventions reach stability.
Do we want to change the above-mentioned expectation set for the users?
There was a problem hiding this comment.
🤷 I have thoughts and opinions, but let's discuss in our next SIG meeting. I do not plan on releasing a new version of this package today anyways.
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
The OpenTracing shim is similar to the prometheus exporter in that it is a core component (i.e., it is declared in the OpenTelemetry specification https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/opentracing.md), but it is not yet ready for a stable release.