Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GrpcNetClient] Clarify impact to SuppressDownstreamInstrumentation #5340

Merged
merged 3 commits into from
Feb 10, 2024
Merged

[GrpcNetClient] Clarify impact to SuppressDownstreamInstrumentation #5340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0c120e
[GrpcNetClient] Clarify impact to SuppressDownstreamInstrumentation
alanwest Feb 9, 2024
376cb7f
Merge branch 'main' into alanwest/suppress-clarification
alanwest Feb 10, 2024
7a4300e
Update src/OpenTelemetry.Instrumentation.GrpcNetClient/CHANGELOG.md
alanwest Feb 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/OpenTelemetry.Instrumentation.GrpcNetClient/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,15 @@

Released 2024-Feb-09

* **Breaking Change** :
* **Breaking Change**:
Please be advised that the
[SuppressDownstreamInstrumentation](https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/src/OpenTelemetry.Instrumentation.GrpcNetClient#suppressdownstreaminstrumentation)
option will no longer be supported when used with certain versions of
`OpenTelemetry.Instrumentation.Http` package. Check out this
option no longer works when used in conjunction with the
`OpenTelemetry.Instrumentation.Http` package version `1.6.0` or greater.
This is not a result of a change in the `OpenTelemetry.Instrumentation.GrpcNetClient`
package therefore this also affects versions prior to this release. See this
[issue](https://github.com/open-telemetry/opentelemetry-dotnet/issues/5092)
for details and workaround.
([#5077](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5077))
* Removed support for the `OTEL_SEMCONV_STABILITY_OPT_IN` environment variable
which toggled the use of the new conventions for the
[server, client, and shared network attributes](https://github.com/open-telemetry/semantic-conventions/blob/v1.23.0/docs/general/attributes.md#server-client-and-shared-network-attributes).
Expand Down
5 changes: 5 additions & 0 deletions src/OpenTelemetry.Instrumentation.GrpcNetClient/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,11 @@ This instrumentation can be configured to change the default behavior by using

### SuppressDownstreamInstrumentation

> [!CAUTION]
> `SuppressDownstreamInstrumentation` no longer works when used in conjunction
with the `OpenTelemetry.Instrumentation.Http` package version `1.6.0` and greater.
This option may change or even be removed in a future release.

This option prevents downstream instrumentation from being invoked.
Grpc.Net.Client is built on top of HttpClient. When instrumentation for both
libraries is enabled, `SuppressDownstreamInstrumentation` prevents the
Expand Down