Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Cleanup shared code #5622

Merged
merged 6 commits into from
May 17, 2024
Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented May 16, 2024

Related to open-telemetry/opentelemetry-dotnet-contrib#1806

Changes

Cleanup after

  • moving shared tests to the contrib resporitory
  • moving semantic convention to contrib repository. Keep only used attributes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.76%. Comparing base (6250307) to head (b30490f).
Report is 228 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5622      +/-   ##
==========================================
+ Coverage   83.38%   85.76%   +2.38%     
==========================================
  Files         297      254      -43     
  Lines       12531    11016    -1515     
==========================================
- Hits        10449     9448    -1001     
+ Misses       2082     1568     -514     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 85.38% <ø> (?)
unittests-Solution-Stable 85.75% <ø> (?)
unittests-Unstable-Core 19.77% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 115 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review May 16, 2024 06:41
@Kielek Kielek requested a review from a team May 16, 2024 06:41
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor questions (non-blocking)

public const string AttributeUrlFull = "url.full"; // replaces: "http.url" (AttributeHttpUrl)
public const string AttributeUrlPath = "url.path"; // replaces: "http.target" (AttributeHttpTarget)
public const string AttributeUrlQuery = "url.query";
public const string AttributeUrlScheme = "url.scheme"; // replaces: "http.scheme" (AttributeHttpScheme)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an early effort (#5432) to sync the shared files between opentelemetry-dotnet and opentelemetry-dotnet-contrib. We might either need to keep the files in sync or as Reiley recommended move these attributes to actual implementation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this repository needs only small subset of full semantic convetion from contrib repository. We can move to actual implementation, but it could be more error prone (two copies of the same string). I would not expect frequent changes in attributes/resources needed in this repository (most of them already should be stable).

@CodeBlanch CodeBlanch changed the title Cleanup shared code [repo] Cleanup shared code May 17, 2024
@CodeBlanch CodeBlanch merged commit b444464 into open-telemetry:main May 17, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants