Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Remove .NET 7 target #5795

Merged
merged 6 commits into from
Aug 21, 2024

Conversation

xiang17
Copy link
Contributor

@xiang17 xiang17 commented Aug 20, 2024

Fixes #5639.
Design discussion issue #5639.

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
    * [ ] Changes in public API reviewed (if applicable)

@github-actions github-actions bot added infra Infra work - CI/CD, code coverage, linters dependencies Pull requests that update a dependency file labels Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.29%. Comparing base (6250307) to head (d609a57).
Report is 297 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5795      +/-   ##
==========================================
+ Coverage   83.38%   86.29%   +2.90%     
==========================================
  Files         297      256      -41     
  Lines       12531    11138    -1393     
==========================================
- Hits        10449     9611     -838     
+ Misses       2082     1527     -555     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 85.93% <ø> (?)
unittests-Project-Stable 86.18% <ø> (?)
unittests-Solution 86.24% <ø> (?)
unittests-UnstableCoreLibraries-Experimental 85.76% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 207 files with indirect coverage changes

@github-actions github-actions bot added pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package labels Aug 20, 2024
@xiang17 xiang17 marked this pull request as ready for review August 20, 2024 22:41
@xiang17 xiang17 requested a review from a team August 20, 2024 22:41
@github-actions github-actions bot removed pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package labels Aug 20, 2024
@CodeBlanch CodeBlanch changed the title Remove .NET 7 TargetFramework [repo] Remove .NET 7 target Aug 21, 2024
@CodeBlanch CodeBlanch merged commit c483222 into open-telemetry:main Aug 21, 2024
42 checks passed
@xiang17 xiang17 deleted the xiang17/RemoveDotnet7 branch August 21, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove .NET 7 TFM
3 participants