[Api] Nullable #5801
Merged
[Api] Nullable #5801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pkg:OpenTelemetry.Api
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5801 +/- ##
==========================================
+ Coverage 83.38% 86.33% +2.95%
==========================================
Files 297 257 -40
Lines 12531 11193 -1338
==========================================
- Hits 10449 9664 -785
+ Misses 2082 1529 -553
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Kielek
force-pushed
the
api-mark-as-nullable
branch
2 times, most recently
from
de9f690
to
8ebf150
Compare
Kielek
force-pushed
the
api-mark-as-nullable
branch
from
8ebf150
to
8bf04e4
Compare
Kielek
approved these changes
Aug 30, 2024
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
Kielek
removed
the
Stale
| @@ -7,7 +7,7 @@ namespace OpenTelemetry.Metrics; | |||
|
|
|||
| internal sealed class PullMetricScope : IDisposable | |||
| { | |||
| private static readonly RuntimeContextSlot<bool> Slot = RuntimeContext.RegisterSlot<bool>("otel.pull_metric"); | |||
| private static readonly RuntimeContextSlot<bool> Slot = RuntimeContext.RegisterSlot<bool>("otel.pull_metric")!; | |||
There was a problem hiding this comment.
I think this one needs a closer look.
I'm not familiar with the RuntimeContext api. If the RegisterSlot method can return a nullable, that might suggest something failed.
There was a problem hiding this comment.
Fixed in fe4d9bf
I double checked. There is no possibility to return null (at least as long someone does no play with reflection with contextSlotType field in RuntimeContext class.
github-actions
bot
removed
the
pkg:OpenTelemetry
3 tasks
TimothyMothra
approved these changes
Sep 19, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3958
Changes
OpenTelemety.Api mark as nullable
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes