Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk] Improve readability of TracerProviderSdk initialization code #5810

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Aug 29, 2024

Fixes #5809
Design discussion issue #

Changes

TracerProviderSdk - avoid hiding field by local variable

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team August 29, 2024 08:46
@Kielek Kielek mentioned this pull request Aug 29, 2024
@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.26%. Comparing base (6250307) to head (5e2585b).
Report is 304 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5810      +/-   ##
==========================================
+ Coverage   83.38%   86.26%   +2.87%     
==========================================
  Files         297      257      -40     
  Lines       12531    11150    -1381     
==========================================
- Hits        10449     9618     -831     
+ Misses       2082     1532     -550     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 86.23% <100.00%> (?)
unittests-Project-Stable 86.19% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/OpenTelemetry/Trace/TracerProviderSdk.cs 99.36% <100.00%> (+0.08%) ⬆️

... and 212 files with indirect coverage changes

@CodeBlanch CodeBlanch changed the title TracerProviderSdk - avoid hiding field by local variable [sdk] Improve readability of TracerProviderSdk initialization code Sep 4, 2024
@CodeBlanch CodeBlanch merged commit 1479686 into open-telemetry:main Sep 4, 2024
34 checks passed
@Kielek Kielek deleted the avoid-hiding-fields branch September 4, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused ActivityListener
4 participants