use some collection expressions #6106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
ysolomchenko
approved these changes
Jan 28, 2025
Kielek
reviewed
Jan 29, 2025
| @@ -29,19 +29,19 @@ public static void Main() | |||
| .AddView(instrumentName: "MyCounter", name: "MyCounterRenamed") | |||
|
|
|||
| // Change Histogram boundaries using the Explicit Bucket Histogram aggregation. | |||
| .AddView(instrumentName: "MyHistogram", new ExplicitBucketHistogramConfiguration() { Boundaries = new double[] { 10, 20 } }) | |||
| .AddView(instrumentName: "MyHistogram", new ExplicitBucketHistogramConfiguration() { Boundaries = [10, 20] }) | |||
There was a problem hiding this comment.
Just to highlight that we are creating double's array. It affects couple of other places.
Suggested change
| .AddView(instrumentName: "MyHistogram", new ExplicitBucketHistogramConfiguration() { Boundaries = [10, 20] }) | |
| .AddView(instrumentName: "MyHistogram", new ExplicitBucketHistogramConfiguration() { Boundaries = [10.0, 20.0] }) |
There was a problem hiding this comment.
You need to fix other places.
There was a problem hiding this comment.
I checked this and Boundaries is a double array so I think this is safe. The compiler will reject an int array.
However since this is a doc example, I'm good if we want to insist on specifying the types here.
Co-authored-by: Piotr Kiełkowicz <[email protected]>
Kielek
requested changes
Jan 31, 2025
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6106 +/- ##
==========================================
- Coverage 86.39% 86.37% -0.02%
==========================================
Files 257 257
Lines 11640 11625 -15
==========================================
- Hits 10056 10041 -15
Misses 1584 1584
|
github-actions
bot
removed
the
Stale
Kielek
approved these changes
Feb 13, 2025
Co-authored-by: Piotr Kiełkowicz <[email protected]>
Co-authored-by: Piotr Kiełkowicz <[email protected]>
|
@SimonCropp, sorry, it needs to be |
Kielek
reviewed
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue #
Changes
IMO they are more readable. and in many scenarios result in better perf
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes