Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename struct traceFramesCounts -> traceEvents #133

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Rename struct traceFramesCounts -> traceEvents #133

merged 4 commits into from
Sep 16, 2024

Conversation

rockdaboot
Copy link
Contributor

The Counts seems to be a historic left-over.

@rockdaboot rockdaboot self-assigned this Aug 23, 2024
@rockdaboot rockdaboot requested review from a team August 23, 2024 11:28
christos68k
christos68k approved these changes Aug 26, 2024
View reviewed changes
reporter/otlp_reporter.go Outdated Show resolved Hide resolved
athre0z
athre0z approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@athre0z athre0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rockdaboot rockdaboot merged commit 9dc96fd into open-telemetry:main Sep 16, 2024
23 checks passed
@rockdaboot rockdaboot deleted the drop-count-from-events branch September 16, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athre0z athre0z athre0z approved these changes

@christos68k christos68k christos68k approved these changes

Assignees

@rockdaboot rockdaboot

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rockdaboot @athre0z @christos68k