-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to run without syscall tracepoints, if possible. #175
Attempt to run without syscall tracepoints, if possible. #175
Conversation
9b369d0
to
b417df1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@umanwizard Are you working on the feedback or do you need help to finalize this PR? |
Sorry, I dropped this. I'll address the feedback and send a new version soon. |
This implements the proposal in open-telemetry#173 . Please see there for full details.
I'm not sure I understand why we should remove the integration test. Isn't it still useful to have this integration test run? We just need to ensure that it is always running in an environment that has syscall probes available (which is the vast majority of environments) |
c2e91c2
to
0774952
Compare
With #205 a test was added that covers also the functionality of the named integration test for the tracepobe. And instead of a specific tracepoint that is written for the integration test, #205 tests the tracepoint that is actually used while running the eBPF profiler agent. |
Okay. In that case we can indeed remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the PR only the updated support/ebpf/tracer.ebpf.release.arm64
is provided. Please also add the updated support/ebpf/tracer.ebpf.release.amd64
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
This implements the proposal in
#173 . Please see there for full details.