Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executables, reporter: refactor towards statelessness #201

Merged
merged 5 commits into from
Oct 25, 2024
Merged

executables, reporter: refactor towards statelessness #201

merged 5 commits into from
Oct 25, 2024

Conversation

rockdaboot
Copy link
Contributor

Expose the cached status for executable metadata to callers of SymbolReporter.ExecutableMetadata().

Improvements

  • the reporter module can now control which executable metadata needs to be fetched
  • fixes OTLP to re-fetch executable metadata if its internal lru already evicted earlier metadata

reference: #121

@rockdaboot rockdaboot self-assigned this Oct 23, 2024
@rockdaboot rockdaboot requested review from a team as code owners October 23, 2024 16:22
@rockdaboot rockdaboot mentioned this pull request Oct 23, 2024
Closed
8 tasks
christos68k
christos68k approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@christos68k christos68k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fabled
fabled approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@fabled fabled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Suggestion to fix existing unrelated bug while at it, but this can be a separate PR also.

interpreter/dotnet/instance.go Outdated Show resolved Hide resolved
@rockdaboot rockdaboot merged commit 7fa5b1e into open-telemetry:main Oct 25, 2024
23 checks passed
@rockdaboot rockdaboot deleted the stateless-executable-reporting branch October 25, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabled fabled fabled approved these changes

@christos68k christos68k christos68k approved these changes

Assignees

@rockdaboot rockdaboot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rockdaboot @fabled @christos68k