Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OpenTelemetry OCI S3 bucket for coredump testing #217

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Use OpenTelemetry OCI S3 bucket for coredump testing #217

merged 2 commits into from
Oct 31, 2024

Conversation

fabled
Copy link
Contributor

@fabled fabled commented Oct 30, 2024 •
edited
Loading

Enable coredump tests

fixes #183

@fabled fabled requested review from a team as code owners October 30, 2024 18:16
@fabled
Fix hashFiles to calculate the json files
2269e6e 
the expansion is not done inside the literal string
christos68k
christos68k approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@christos68k christos68k left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

I ran the test from a clean slate which downloaded all cores without issues.

@christos68k christos68k merged commit c2e8af7 into open-telemetry:main Oct 31, 2024
23 checks passed
@athre0z
Copy link
Member

athre0z commented Oct 31, 2024

Great to have this back -- thanks for finishing this! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christos68k christos68k christos68k approved these changes

@florianl florianl florianl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the coredump unwinder test suite
4 participants
@fabled @athre0z @florianl @christos68k