Go: replace aws-sdk-go with aws-sdk-go-v2 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[AWS](https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/) announed the deprication of aws-sdk-go. Starting with July 30, 2024 this API will be in maintenance mode and with July 31, 2025 this API will be end of support. Therefore replace aws-sdk-go with its successor aws-sdk-go-v2. Signed-off-by: Florian Lehner <[email protected]>
florianl
force-pushed
the
flo-drop-aws-v1
branch
from
f8a4fcc
to
72b7d6b
Compare
rockdaboot
reviewed
Jun 25, 2024
| @@ -33,7 +36,7 @@ func getS3ObjectList(client *s3.S3, bucket, prefix string, itemLimit int) ([]*s3 | |||
|
|
|||
| objects = append(objects, resp.Contents...) | |||
|
|
|||
| if int64(len(resp.Contents)) != batchSize { | |||
| if int32(len(resp.Contents)) != batchSize { | |||
There was a problem hiding this comment.
nit: slightly safer
Suggested change
| if int32(len(resp.Contents)) != batchSize { | |
| if len(resp.Contents) != int(batchSize) { |
rockdaboot
approved these changes
Jun 25, 2024
rockdaboot
pushed a commit
that referenced
this pull request
Jul 10, 2024
Signed-off-by: Florian Lehner <[email protected]>
rockdaboot
pushed a commit
that referenced
this pull request
Aug 7, 2024
Signed-off-by: Florian Lehner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS announed the deprication of aws-sdk-go. Starting with July 30, 2024 this API will be in maintenance mode and with July 31, 2025 this API will be end of support.
Therefore replace aws-sdk-go with its successor aws-sdk-go-v2.