Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate otelmemcache, otelgocql #4164

Merged

Conversation

pellared
Copy link
Member

@pellared pellared commented Aug 9, 2023

Towards #2834 and #4163

@pellared pellared force-pushed the deprecate-modules-without-codeowners branch from 4a34e70 to d7d8894 Compare August 9, 2023 11:50
CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
@pellared pellared force-pushed the deprecate-modules-without-codeowners branch from f2449a8 to 7b43936 Compare August 9, 2023 13:01
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #4164 (2b0c613) into main (417fc12) will increase coverage by 2.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4164     +/-   ##
=======================================
+ Coverage   79.4%   81.6%   +2.2%     
=======================================
  Files        166     170      +4     
  Lines      10363   10423     +60     
=======================================
+ Hits        8233    8511    +278     
+ Misses      1996    1765    -231     
- Partials     134     147     +13     

CODEOWNERS Outdated Show resolved Hide resolved
@pellared pellared changed the title Deprecate modules that do not have owners Deprecate otelmemcache, otelgocql, zpages Aug 9, 2023
@pellared pellared marked this pull request as ready for review August 9, 2023 14:05
@pellared pellared requested a review from a team August 9, 2023 14:05
@pellared pellared marked this pull request as draft August 10, 2023 18:05
@pellared
Copy link
Member Author

pellared commented Aug 10, 2023

TODO: Do NOT deprecate zpages as it looks as being used by the Collector. @dashpole offered to be a codeowner of the module.

EDIT: Done 0310edd

@pellared pellared changed the title Deprecate otelmemcache, otelgocql, zpages Deprecate otelmemcache, otelgocql Aug 11, 2023
zpages/doc.go Show resolved Hide resolved
@pellared pellared marked this pull request as ready for review August 11, 2023 08:31
@pellared
Copy link
Member Author

CODEOWNERS Outdated Show resolved Hide resolved
@pellared pellared requested a review from dashpole as a code owner September 5, 2023 11:59
@pellared pellared requested a review from MrAlias September 5, 2023 12:00
CHANGELOG.md Outdated Show resolved Hide resolved
@pellared pellared merged commit 3ad5a2c into open-telemetry:main Sep 6, 2023
@pellared pellared deleted the deprecate-modules-without-codeowners branch September 6, 2023 08:09
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants