-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gin exporter: support reading Client IP from custom headers (and make sure proxy is trusted) #6095
Open
ItalyPaleAle
wants to merge
17
commits into
open-telemetry:main
Choose a base branch
from
ItalyPaleAle:gin-clientip
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Sep 8, 2024
-
Gin exporter: support reading Client IP from custom headers (and make…
… sure proxy is trusted) With Gin, it's possible to configure the server to read the Client IP from custom headers; examples include `X-Real-Ip` or `CF-Connecting-IP`. This PR makes it possible to set as span attribute the same IP that Gin reads. Additionally, it makes sure that headers such as "X-Forwarded-For" are used only if Gin is configured to trust the upstream server PS: Also fixed unit tests, where there were assertions inside handlers, which are executed in separate goroutines
Configuration menu - View commit details
-
Copy full SHA for 0273b8c - Browse repository at this point
Copy the full SHA 0273b8cView commit details
Commits on Sep 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 66ab057 - Browse repository at this point
Copy the full SHA 66ab057View commit details -
Configuration menu - View commit details
-
Copy full SHA for e978ded - Browse repository at this point
Copy the full SHA e978dedView commit details -
Configuration menu - View commit details
-
Copy full SHA for d2bac00 - Browse repository at this point
Copy the full SHA d2bac00View commit details
Commits on Sep 10, 2024
-
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
…y-go-contrib into gin-clientip
Configuration menu - View commit details
-
Copy full SHA for 83866e7 - Browse repository at this point
Copy the full SHA 83866e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69fc65d - Browse repository at this point
Copy the full SHA 69fc65dView commit details
Commits on Sep 11, 2024
-
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
…y-go-contrib into gin-clientip
Configuration menu - View commit details
-
Copy full SHA for 27ffeda - Browse repository at this point
Copy the full SHA 27ffedaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ea8dec - Browse repository at this point
Copy the full SHA 5ea8decView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2046f0b - Browse repository at this point
Copy the full SHA 2046f0bView commit details
Commits on Sep 17, 2024
-
Co-authored-by: Damien Mathieu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5cc0025 - Browse repository at this point
Copy the full SHA 5cc0025View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66533fe - Browse repository at this point
Copy the full SHA 66533feView commit details
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4b7a39a - Browse repository at this point
Copy the full SHA 4b7a39aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9149000 - Browse repository at this point
Copy the full SHA 9149000View commit details
Commits on Sep 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3a07c40 - Browse repository at this point
Copy the full SHA 3a07c40View commit details
Commits on Sep 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fe2b800 - Browse repository at this point
Copy the full SHA fe2b800View commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1de3e69 - Browse repository at this point
Copy the full SHA 1de3e69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 666002a - Browse repository at this point
Copy the full SHA 666002aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.