Skip to content

Commit

Permalink
[chore]: enable negative-positive rule from testifylint (#5849)
Browse files Browse the repository at this point in the history
Testifylint is a linter that provides best practices with the use of
testify.

This PR enables
[negative-positive](https://github.com/Antonboom/testifylint?tab=readme-ov-file#negative-positive)
rule from [testifylint](https://github.com/Antonboom/testifylint)

Signed-off-by: Matthieu MOREL <[email protected]>
  • Loading branch information
mmorel-35 authored Sep 30, 2024
1 parent 481f498 commit 469f3d7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -308,5 +308,4 @@ linters-settings:
disable:
- float-compare
- go-require
- negative-positive
- require-error
4 changes: 2 additions & 2 deletions sdk/metric/internal/aggregate/exponential_histogram_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ func testExpoHistogramMinMaxSumInt64(t *testing.T) {

assert.Equal(t, tt.expected.max, dp.max)
assert.Equal(t, tt.expected.min, dp.min)
assert.Equal(t, tt.expected.sum, dp.sum)
assert.InDelta(t, tt.expected.sum, dp.sum, 0.01)
})
}
}
Expand Down Expand Up @@ -222,7 +222,7 @@ func testExpoHistogramMinMaxSumFloat64(t *testing.T) {

assert.Equal(t, tt.expected.max, dp.max)
assert.Equal(t, tt.expected.min, dp.min)
assert.Equal(t, tt.expected.sum, dp.sum)
assert.InDelta(t, tt.expected.sum, dp.sum, 0.01)
})
}
}
Expand Down

0 comments on commit 469f3d7

Please sign in to comment.