Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate internal/retry in otlploghttp #5165

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Generate internal/retry in otlploghttp #5165

merged 5 commits into from
Apr 8, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Apr 5, 2024 •
edited
Loading

Part of #5057

@MrAlias MrAlias added area:logs Part of OpenTelemetry logs Skip Changelog PRs that do not require a CHANGELOG.md entry pkg:exporter:otlp Related to the OTLP exporter package labels Apr 5, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.77778% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.8%. Comparing base (d66a661) to head (799da27).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5165   +/-   ##
=====================================
  Coverage   83.8%   83.8%           
=====================================
  Files        253     254    +1     
  Lines      16487   16532   +45     
=====================================
+ Hits       13820   13864   +44     
- Misses      2374    2375    +1     
  Partials     293     293
Files Coverage Δ
exporters/otlp/otlplog/otlploghttp/config.go 12.0% <ø> (ø)
...s/otlp/otlplog/otlploghttp/internal/retry/retry.go 97.7% <97.7%> (ø)

@MrAlias MrAlias marked this pull request as ready for review April 5, 2024 20:04
@pellared pellared merged commit 014c6fc into open-telemetry:main Apr 8, 2024
25 of 26 checks passed
@MrAlias MrAlias mentioned this pull request Apr 8, 2024
Closed
15 tasks
@MrAlias MrAlias added this to the v1.26.0 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@pellared pellared pellared approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung

Assignees
No one assigned
Labels
area:logs Part of OpenTelemetry logs pkg:exporter:otlp Related to the OTLP exporter package Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
Go: Logs (GA)
Status: Done
Milestone
v1.26.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MrAlias @dmathieu @pellared