-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to split the image registry and the repository #1400
base: main
Are you sure you want to change the base?
Allow to split the image registry and the repository #1400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run make generate-examples CHARTS=opentelemetry-collector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need a new example, but can you share the output of the image string being set properly when using the new field and the global field?
0d1363b
to
2b47c03
Compare
I ended up creating the examples. I think they are valuable |
2b47c03
to
e56b1a9
Compare
e56b1a9
to
40097ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aacevedoosorio the new examples give me confidence that this process works, but I don't want to merge this PR with them. Using these options in the values.yaml is straight forward for an end-user even if the logic to build the string is kinda complex.
I get your point. Let me revert those examples. |
…mageRegistry" This reverts commit 40097ca.
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@aacevedoosorio needs a rebase and then we'll be good. |
The current helm chart allows to set a
global.imageRegistry
in combination with the repository configured. But it would be nice as well to split the repository into the default registry for charts that use the open-telemetry chart as a subchart and have a default predefined repository.