Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of parent-override behaviour for inferred-spans #1533

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JonasKunz
Copy link
Contributor

Description:

The inferred spans extension sometimes has to insert inferredspans inbetween the parent-child relationship of normal spans for correctness.

This is however not directly possible, that is why we represent this as a span-link on the inferred spans. This PR adds a configuration hook to fully customize this behaviour with a custom handler.

The main reason for adding this is because in our elastic vendor distro of the opentelemetry agent we are still shipping the pre-contribution version of inferred spans. We currently still have to do this, because there these special span links are marked with an elastic.is_child instead of just is_child attribute and older versions of our backend rely on this elastic-specific attribute.

With this change we can switch to this contributed version of inferred spans and add the elastic.is_child attribute on the span link via the customization hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants