Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding propagation of tracing headers #8786

Closed
giovanniberti opened this issue Jun 22, 2023 · 3 comments
Closed

Allow overriding propagation of tracing headers #8786

giovanniberti opened this issue Jun 22, 2023 · 3 comments
Labels
enhancement New feature or request needs author feedback Waiting for additional feedback from the author stale

Comments

@giovanniberti
Copy link

giovanniberti commented Jun 22, 2023

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.

Azure API Management without Diagnostic Logs enabled injects traceparent headers with the sampling flag set to 0.
This causes the agent to not emit traces on instrumented services, and there's no easy way to override this behaviour from APIM without enabliing Diagnostic Logs.

Describe the solution you'd like
A clear and concise description of what you want to happen.

I would like a configuration option to allow the agent to ignore incoming tracing headers, like this option on the Elastic APM.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

An alternative would be to use AlwaysOn sampler, but I'd rather have something more fine-grained if possible :)

Additional context
Add any other context or screenshots about the feature request here.

@giovanniberti giovanniberti added the enhancement New feature or request label Jun 22, 2023
@mateuszrzeszutek
Copy link
Member

Related links: #8038, open-telemetry/opentelemetry-specification#1633

@trask
Copy link
Member

trask commented Aug 10, 2023

hi @giovanniberti! you could use a java agent extension to provide your own sampler which is not "parent based" (i.e. ignores the traceparent sampling flag)

@trask trask added the needs author feedback Waiting for additional feedback from the author label Aug 10, 2023
@github-actions
Copy link
Contributor

This has been automatically marked as stale because it has been marked as needing author feedback and has not had any activity for 7 days. It will be closed automatically if there is no response from the author within 7 additional days from this comment.

@github-actions github-actions bot added the stale label Aug 17, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs author feedback Waiting for additional feedback from the author stale
Projects
None yet
Development

No branches or pull requests

3 participants