Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: instruments com.twitter.util-stats #11756

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dmarkwat
Copy link
Contributor

@dmarkwat dmarkwat commented Jul 7, 2024

Instruments twitter's util-stats to complement existing finagle tracing observability in finagle-http.

Explicitly handled, is a mapping most closely according to twitter-util-stats' own PrometheusExporter as Prometheus is the closest relative to otel represented in the stack (AFAICT), but with the additional metadata of "hierarchical names" carried forward to otel via a designated label. This is done because many names -- "hierarchical" names in particular -- contain dimensional values but which aren't mapped to twitter-util-stats labels directly, and so their otel counterparts lose fidelity when mapped without them.

The result is a more granular set of metrics, but which remain largely constrained by the nature of the source library where high cardinality of names and labels is still discouraged to a great extent.

Explicitly omitted: translation of twitter-util-stat's Stat metric type. These are equivalent to otel's deprecated Summary metric type and are therefore not a priority for the present iteration. As this is effectively a shift to Histograms as stand-in, compatibility/accuracy testing relative to the Stat metrics, will be lower than if the translation were 1:1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant