-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Semconv to 1.26 #11792
Upgrade Semconv to 1.26 #11792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few minor (non blocking) typos.
...a/io/opentelemetry/instrumentation/api/incubator/semconv/db/DbClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
...a/io/opentelemetry/instrumentation/api/incubator/semconv/db/DbClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
.../io/opentelemetry/instrumentation/api/incubator/semconv/db/SqlClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
.../io/opentelemetry/instrumentation/api/incubator/semconv/db/SqlClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
Unfortunately, they way I see it, this PR can not be merged as it is. Have a look at https://opentelemetry.io/docs/specs/semconv/database/ Pay attention to
Messaging semantic conventions https://opentelemetry.io/docs/specs/semconv/messaging/messaging-spans/ have a similar warning. |
For From what I remember we plan to make the stable database conventions the default for next major release of instrumentation (so 3.x). Do we have similar plans for other attributes that are covered by this PR (rpc and messsaging) ? |
…nstrumentation/api/incubator/semconv/db/DbClientAttributesExtractor.java Co-authored-by: SylvainJuge <[email protected]>
…nstrumentation/api/incubator/semconv/db/DbClientAttributesExtractor.java Co-authored-by: SylvainJuge <[email protected]>
…nstrumentation/api/incubator/semconv/db/SqlClientAttributesExtractor.java Co-authored-by: SylvainJuge <[email protected]>
…nstrumentation/api/incubator/semconv/db/SqlClientAttributesExtractor.java Co-authored-by: SylvainJuge <[email protected]>
@laurit @SylvainJuge Thank you for your responses. I noticed that Should we add SemconvStability back and include these values:
|
Yes, i am adding it back while prototyping stable database semconv (#11575). however, it's for |
Thank you. I will continue to push this forward when your PR is completed, although by then, we might be able to upgrade to version |
Close by #12292 |
v1.26.0 has been released.
Replace the deprecated attributes with new ones.