make rmi indy-ready #14845
Merged
make rmi indy-ready #14845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstrumentation into indy-rmi2
|
@laurit the build has been running for hours and seems stuck, but I can't cancel it. Can you cancel it and/or restart it ? |
…nstrumentation into indy-rmi2
JonasKunz
approved these changes
Oct 7, 2025
...in/java/io/opentelemetry/javaagent/instrumentation/rmi/client/UnicastRefInstrumentation.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Oct 8, 2025
...n/java/io/opentelemetry/javaagent/instrumentation/rmi/context/client/VirtualFieldHelper.java
Outdated
Show resolved
Hide resolved
…nstrumentation into indy-rmi2
laurit
reviewed
Oct 9, 2025
| logger.log( | ||
| FINE, | ||
| "Exposing package '{0}' in module '{1}' to module '{2}'", | ||
| "Exposing package {0} in module {1} to module {2}", |
There was a problem hiding this comment.
The problem here is that with extra quotes, the variables were not written to the template, I've simply removed them to avoid having to use escaping.
There was a problem hiding this comment.
Thanks. This appears to be a side-effect of our logging implementation that uses java.text.MessageFormat. If I remember correctly adding quotes like that would have been fine with slf4j that we use as the underlying implementation.
laurit
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13031 for rmi instrumentation