Use health port for jaeger container startup check. #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
Oberon00
reviewed
Jan 5, 2021
| @@ -67,7 +67,7 @@ | |||
| public static GenericContainer<?> collectorContainer = | |||
| new GenericContainer<>( | |||
| DockerImageName.parse( | |||
| "open-telemetry-docker-dev.bintray.io/java-test-containers:otel-collector-dev")) | |||
| "ghcr.io/open-telemetry/java-test-containers:otel-collector-dev")) | |||
There was a problem hiding this comment.
This change seems unrelated to the PR purpose. What is the reason for using a different registry?
There was a problem hiding this comment.
For a long time ever since starting to use bintray for agent smoke tests, we found the push reliability to be close to 0. GHCR has yet to fail :)
I had already updated our mirror workflow
But forgot to update the tests after that run once.
It's indeed not strongly related to the purpose but touches the same lines mostly, please let me be a bit lazy with it still being a small PR :D
Oberon00
approved these changes
Jan 5, 2021
|
@anuraaga Thanks for the quick response to my findings with this quick fix! 🏆 |
jkwatson
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also migrate images to the ghcr ones I had set up but forgot to apply the change for.
Fixes #1871 (hopefully, will reopen if this doesn't actually fix it)