add comment, add to changelog

open-telemetry · Feb 22, 2024 · 03e84e3 · 03e84e3
1 parent 0efb5da
commit 03e84e3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,7 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/
 
 ### :bug: (Bug Fix)
 
+* fix(sdk-trace-web): fix invalid timings in span events [#4486](https://github.com/open-telemetry/opentelemetry-js/pull/4486) @Abinet18
 * fix(sdk-metrics): handle zero bucket counts in exponential histogram merge [#4459](https://github.com/open-telemetry/opentelemetry-js/pull/4459) @mwear
 * fix(sdk-metrics): ignore `NaN` value recordings in Histograms [#4455](https://github.com/open-telemetry/opentelemetry-js/pull/4455) @pichlermarc
   * fixes a bug where recording `NaN` on a histogram would result in the sum of bucket count values not matching the overall count

diff --git a/packages/opentelemetry-sdk-trace-web/src/utils.ts b/packages/opentelemetry-sdk-trace-web/src/utils.ts
@@ -69,6 +69,8 @@ export function addSpanNetworkEvent(
   ) {
     let perfTime = entries[performanceName];
     const refName = refPerfName || PTN.FETCH_START;
+    // Use a reference time whcih is the earliest possible value so that the performance timing are earlier can be corrected to this reference time
+    // using FETCH START time in case no reference is provided
     if (hasKey(entries, refName) && typeof entries[refName] === 'number') {
       perfTime = Math.max(perfTime || 0, entries[refName] || 0);
     }