Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codeql): run workflow for pushes to main and pull requests #4110

Merged

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

CodeQL only runs on a schedule and on workflow_dispatch at the moment.
This PR applies the Security SIGs recommendation to run CodeQL on pushes to main. The PR also removes the schedule but retains the ability to run on workflow_dispatch.

See #4101
See open-telemetry/sig-security#15

Type of change

  • internal

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #4110 (ad46cf1) into main (f6ebf0e) will not change coverage.
The diff coverage is n/a.

❗ Current head ad46cf1 differs from pull request most recent head d11fb36. Consider uploading reports for the commit d11fb36 to get more accurate results

@@           Coverage Diff           @@
##             main    #4110   +/-   ##
=======================================
  Coverage   90.52%   90.52%           
=======================================
  Files         159      159           
  Lines        3757     3757           
  Branches      835      835           
=======================================
  Hits         3401     3401           
  Misses        356      356           

@pichlermarc
Copy link
Member Author

Tests failing due to npm@10 not supporting node 16 and 14 - see #4111

Copy link

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change @pichlermarc, looks great

@pichlermarc pichlermarc merged commit 4f28f90 into open-telemetry:main Sep 12, 2023
15 checks passed
@pichlermarc pichlermarc deleted the fix/code-ql-trigger branch September 12, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants