-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(codeql): run workflow for pushes to main and pull requests #4110
fix(codeql): run workflow for pushes to main and pull requests #4110
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4110 +/- ##
=======================================
Coverage 90.52% 90.52%
=======================================
Files 159 159
Lines 3757 3757
Branches 835 835
=======================================
Hits 3401 3401
Misses 356 356 |
Tests failing due to npm@10 not supporting node 16 and 14 - see #4111 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change @pichlermarc, looks great
Which problem is this PR solving?
CodeQL only runs on a schedule and on
workflow_dispatch
at the moment.This PR applies the Security SIGs recommendation to run CodeQL on pushes to main. The PR also removes the schedule but retains the ability to run on
workflow_dispatch
.See #4101
See open-telemetry/sig-security#15
Type of change