Added limitation in ot-shim readme #5072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pichlermarc I'd appreciate your review. Thanks. |
pichlermarc
reviewed
Oct 17, 2024
pichlermarc
added
document
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5072 +/- ##
==========================================
- Coverage 93.18% 93.17% -0.02%
==========================================
Files 315 315
Lines 8086 8086
Branches 1617 1617
==========================================
- Hits 7535 7534 -1
- Misses 551 552 +1 |
Co-authored-by: Marc Pichler <[email protected]>
Co-authored-by: Marc Pichler <[email protected]>
@pichlermarc I have committed your suggestions. Thanks. |
pichlermarc
approved these changes
Oct 23, 2024
pichlermarc
reviewed
Oct 23, 2024
Annosha
pushed a commit
to Annosha/opentelemetry-js
that referenced
this pull request
Nov 2, 2024
Co-authored-by: Marc Pichler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR informs users that the OpenTracing shim doesn't include a scope manager.
Fixes #2700
Short description of the changes
This PR updates the OpenTracing shim
Readme.mdfile by adding a limitation section; informing users that the OpenTracing shim doesn't include a scope manager.Type of change
How Has This Been Tested?
No test was created/run
Checklist: