fix(sdk-metrics): await export when async attributes are pending #5126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5126 +/- ##
==========================================
+ Coverage 93.17% 93.20% +0.03%
==========================================
Files 315 315
Lines 8086 8084 -2
Branches 1617 1616 -1
==========================================
+ Hits 7534 7535 +1
+ Misses 552 549 -3
|
pichlermarc
force-pushed
the
fix/await-when-async-is-pending
branch
from
e81e944
to
617305a
Compare
…ed when resolving the async resource fails
…is called when resolving the async resource fails
pichlermarc
force-pushed
the
fix/await-when-async-is-pending
branch
from
e3476c0
to
8b372cb
Compare
pichlermarc
added
bug
pichlermarc
commented
Nov 8, 2024
packages/sdk-metrics/test/export/PeriodicExportingMetricReader.test.ts
Outdated
Show resolved
Hide resolved
trentm
approved these changes
Nov 8, 2024
| await resourceMetrics.resource.waitForAsyncAttributes?.(); | ||
| } catch (e) { | ||
| api.diag.debug('Error while resolving async portion of resource: ', e); | ||
| globalErrorHandler(e); |
There was a problem hiding this comment.
TIL about globalErrorHandler.
There was a problem hiding this comment.
globalErrorHandler is a poorly understood and (in my opinion) poorly thought out spec. I'd probably get rid of it if i had the chance.
dyladan
previously requested changes
Nov 8, 2024
dyladan
reviewed
Nov 8, 2024
dyladan
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
When
asyncattributes are pending, we don't await the export, which means that ashutdown()following aforceFlush()will shut down the exporter beforeforceFlush()is completed and the export will be cancelled.Fixes #5116
Type of change
How Has This Been Tested?