Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace deprecated String.prototype.substr() with substring() #5209

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 27, 2024

Which problem is this PR solving?

The String.prototype.substr() is deprecated.

Fixes # (issue)

Short description of the changes

This PR replaces String.prototype.substr() with String.prototype.substring()

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • CI

Checklist:

  • Followed the style guidelines of this project

@trivikr trivikr requested a review from a team as a code owner November 27, 2024 12:56
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.58%. Comparing base (3bf1284) to head (2de272a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5209      +/-   ##
==========================================
- Coverage   94.59%   94.58%   -0.02%     
==========================================
  Files         314      314              
  Lines        7993     7993              
  Branches     1611     1611              
==========================================
- Hits         7561     7560       -1     
- Misses        432      433       +1     
Files with missing lines Coverage Δ
packages/opentelemetry-core/src/common/time.ts 98.55% <100.00%> (ø)
packages/opentelemetry-sdk-trace-base/src/Span.ts 97.61% <100.00%> (ø)

... and 1 file with indirect coverage changes

@trivikr
Copy link
Contributor Author

trivikr commented Nov 27, 2024

The changelog CI failed

Please add a CHANGELOG entry, or add the "Skip Changelog" label if not required.

This is a minor change, for which CHANGELOG entry can be skipped and Skip changelog label can be added.

@david-luna david-luna added this pull request to the merge queue Nov 27, 2024
Merged via the queue into open-telemetry:main with commit 5ad0aa5 Nov 27, 2024
21 of 22 checks passed
@trivikr trivikr deleted the substr-to-substring branch November 27, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants