-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk-*)!: align merge resource behavior with spec #5219
base: next
Are you sure you want to change the base?
feat(sdk-*)!: align merge resource behavior with spec #5219
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #5219 +/- ##
==========================================
- Coverage 93.15% 93.12% -0.04%
==========================================
Files 315 315
Lines 8113 8087 -26
Branches 1633 1627 -6
==========================================
- Hits 7558 7531 -27
- Misses 555 556 +1
|
@@ -53,14 +53,15 @@ const udsAddr = 'unix:///tmp/otlp-metrics.sock'; | |||
type TestParams = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I actually removed all of these tests on main already. I'll open a PR to sync main to next.
It's time again to do so anyway.
Co-authored-by: Marc Pichler <[email protected]>
Which problem is this PR solving?
Aligns SDKs resource merging strategy with the specification:
Fixes #5132
Short description of the changes
mergeResourcesWithDefault
optionType of change
Please delete options that are not relevant.
How Has This Been Tested?
Compiled and ran the tests in all packages.
Checklist: