-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 0.0.0.0 as otlp receiver default address #3126
Comments
|
For services running in kubernetes, the norm is to bind to the 0 address. Binding to pod_ip may be slightly more secure since it is a smaller surface area, but it could result in unexpected behavior, such as when using |
Something you want to work on @led0nk? :) |
Yes, please |
Does it make sense to hide this behaviour behind a feature gate on the operator that we enable once we disable the |
would this featuregate be enabled by default and eventually removed? |
It should be enabled by default once |
Component(s)
collector
Is your feature request related to a problem? Please describe.
The 0.104.0 collector release enables
component.UseLocalHostAsDefaultHost
by default. Since this would be a breaking change for the users, the operator in 0.104.0 reverts this change by updating fields like:4317
or empty fields to0.0.0.0:4317
.Describe the solution you'd like
Maybe it does make sense to use the collector default
localhost
in sidecar scenarios and the$POD_IP
for all the other modes.Update
Add upgrade routine and default webhook entry for the following components(source open-telemetry/opentelemetry-collector#8510 (comment)):
Next:
component.UseLocalHostAsDefaultHost
feature-gate.component.UseLocalHostAsDefaultHost
from defaulting webhookDescribe alternatives you've considered
Keep it like it is today or disable the
component.UseLocalHostAsDefaultHost
featuregate. (Which will be removed in the future).Additional context
#3119 (comment)
The text was updated successfully, but these errors were encountered: