Use 0.0.0.0 as otlp receiver default address #3147
Conversation
|
Something like this @jaronoff97. |
frzifus
force-pushed
the
enable_localhost_fg_otlp_#3126
branch
from
fce3654
to
58c3095
Compare
…erfaces Signed-off-by: Benedikt Bongartz <[email protected]>
frzifus
force-pushed
the
enable_localhost_fg_otlp_#3126
branch
from
58c3095
to
e8a218e
Compare
|
|
||
| // defaultOTLPAddress binds configured otlp receivers to 0.0.0.0 if nothing else | ||
| // is explicitly defined. | ||
| func defaultOTLPAddress(otelcol *OpenTelemetryCollector) error { |
There was a problem hiding this comment.
this is kinda similar to the logic i have for the parsers, im wondering if we could reuse that in the defaulting webhook? like we could have the parsers return the default config and set that in the default webhook?
There was a problem hiding this comment.
I think that makes sense. In case we agree on the general idea, I will spend some time to build it into that. 😃
There was a problem hiding this comment.
yeah i think the general idea makes sense to me, i think doing it in the parsers with the introduction of a new method should be pretty clean
There was a problem hiding this comment.
@jaronoff97 you may want to have a look on the part changed in internal/components.
Its just a draft. What I like is that the component parser becomes a bit more flexible. What I do not like is that components.WithPortMapping has no effect on the default. From my point of view that could lead to confusion.
On the other hand I do not want to glue some magic defaulting into the ComponentPortParser which only has the intention to parse ports.
Any recommendations?
frzifus
changed the title
Description:
operator.collector.UseLocalHostAsDefaultHostthat, when enabled, binds unspecified receiver listener addresses to all interfacesLink to tracking Issue(s):
Testing:
Documentation: