-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump webserver to v1.0.4 #2408
base: main
Are you sure you want to change the base?
bump webserver to v1.0.4 #2408
Conversation
|
For `Nginx` autoinstrumentation, Nginx versions 1.22.0, 1.23.0, and 1.23.1 are supported at this time. The Nginx configuration file is expected to be `/etc/nginx/nginx.conf` by default, if it's different, see following example on how to change it. Instrumentation at this time also expects, that `conf.d` directory is present in the directory, where configuration file resides and that there is a `include <config-file-dir-path>/conf.d/*.conf;` directive in the `http { ... }` section of Nginx configuration file (like it is in the default configuration file of Nginx). You can also adjust OpenTelemetry SDK attributes. Example: | ||
For `Nginx` autoinstrumentation, Nginx versions 1.24.0 and 1.25.3 are supported at this time. The Nginx configuration file is expected to be `/etc/nginx/nginx.conf` by default, if it's different, see following example on how to change it. Instrumentation at this time also expects, that `conf.d` directory is present in the directory, where configuration file resides and that there is a `include <config-file-dir-path>/conf.d/*.conf;` directive in the `http { ... }` section of Nginx configuration file (like it is in the default configuration file of Nginx). You can also adjust OpenTelemetry SDK attributes. Example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're effectively dropping support for versions <1.24, then this is a breaking change and should be documented as such imo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree! How should that be reflected? Should I bump the major?
Only problem is that it can be confusing that the semantic version deviates from the upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add a changelog entry with type breaking_change
. Run make chlog-new
and have a look at the added changelog record.
I'm wondering if we should actually have the operator pick the right version based on the nginx image version. WDYT @jaronoff97 @pavolloffay ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the bump to 1.0.4 is all support for those versions dropped? We definitely should add a changelog calling out the dropping of support. I'm wondering if we should also add a compat matrix for the versions / images to let people know.
Seems like the pipeline fails due to this: open-telemetry/opentelemetry-cpp-contrib#341 |
I've upgraded to v1.0.4 on my ARM image, and |
9e3aa13
to
113c5c9
Compare
Description: Bump webserver instrumentation to v1.0.4.
Link to tracking Issue:
Testing: CI
Documentation: https://github.com/open-telemetry/opentelemetry-cpp-contrib/releases/tag/webserver%2Fv1.0.4