Move CRD convert functionality to v1alpha1 package #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
jaronoff97
reviewed
Mar 4, 2024
| @@ -21,8 +21,6 @@ import ( | |||
| v1 "k8s.io/api/core/v1" | |||
| networkingv1 "k8s.io/api/networking/v1" | |||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | |||
|
|
|||
| "github.com/open-telemetry/opentelemetry-operator/apis/v1alpha1" | |||
There was a problem hiding this comment.
love to see us breaking the cycle :D
jaronoff97
reviewed
Mar 4, 2024
jaronoff97
approved these changes
Mar 4, 2024
frzifus
approved these changes
Mar 4, 2024
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Move CRD convert functionality to v1alpha1 package Signed-off-by: Pavol Loffay <[email protected]> * Fix --------- Signed-off-by: Pavol Loffay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
v1alpha1CRD will implement the conversion webhook. To avoid circular dependencies moving the conversion tov1alpha1Link to tracking Issue(s):
Updates: #2620
Testing:
Documentation: