Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] require Go 1.22 #2747

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

swiatekm
Copy link
Contributor

@swiatekm swiatekm commented Mar 11, 2024

#2741 requires it.

Some of our new dependencies require Go 1.22.
@swiatekm swiatekm requested a review from a team March 11, 2024 13:21
@jaronoff97 jaronoff97 merged commit 2409359 into open-telemetry:main Mar 11, 2024
31 checks passed
Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am asking to define it, since bumping it "randomly" could cause issues when users productive their own opentelemetry-operator distro.

cc @pavolloffay

@@ -1,6 +1,6 @@
module github.com/open-telemetry/opentelemetry-operator

go 1.21
go 1.22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to define a guideline like on the collector when to bump this version?
See: https://github.com/open-telemetry/opentelemetry-collector#compatibility

@swiatekm swiatekm deleted the chore/go122 branch March 11, 2024 14:27
swiatekm added a commit to swiatekm/opentelemetry-operator that referenced this pull request Mar 12, 2024
pavolloffay pushed a commit that referenced this pull request Mar 12, 2024
janario pushed a commit to janario/opentelemetry-operator that referenced this pull request Mar 28, 2024
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants